Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: utils query tests, especially around failure cases #146

Closed
wants to merge 3 commits into from
Closed

WIP: utils query tests, especially around failure cases #146

wants to merge 3 commits into from

Conversation

definitelynotagoblin
Copy link
Collaborator

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@definitelynotagoblin definitelynotagoblin self-assigned this Jul 29, 2024
definitelynotagoblin
definitelynotagoblin commented Jul 30, 2024
View reviewed changes
test/unit/LdapUtilsQueryTest.cs
}

[Fact]
public async Task Query_CancellationRequested_StopsRetrieval()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo: This doesn't really test anything just yet

@definitelynotagoblin definitelynotagoblin changed the title WIP: utils query tests, especially around exception handling WIP: utils query tests, especially around failure cases Jul 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rvazarkar rvazarkar Awaiting requested review from rvazarkar

Assignees

@definitelynotagoblin definitelynotagoblin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@definitelynotagoblin